Fix integer overflow for scene size on 32bit systems #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
|
Turns out file sizes are broken on ingest so we have to wipe all file sizes with a migration. Ideally the scenes table should be rebuilt with integer size column so we don't have to convert int=>string=>float, but rebuilding scenes is a nightmare and there shouldn't be any risk of overflow anymore. |
|
can you bump the schema to version 17 as #988 has updated the schema to 16. |
ghost
force-pushed
the
fix-scenesize-overflow
branch
from
d8cd40c to
d17e9fc
Compare
WithoutPants
approved these changes
Dec 21, 2020
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Fix integer overflow for scene size on 32bit systems * Cast to double in sqlite to prevent potential overflow * Add migration to reset scene sizes and scan logic to repopulate if empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integers are 32bits on 32bit systems, for instance raspberry pis. This causes scene stats to overflow above 2GB and produce garbage numbers.
To output proper int64 we would need to manually set up a StatResultType model and matching resolver. Switching to float has the same effect however, and requires no boilerplate.